ubuntu-post-install icon indicating copy to clipboard operation
ubuntu-post-install copied to clipboard

Third-party package download does not follow redirects

Open dcupif opened this issue 5 years ago • 2 comments

Hi,

Thanks for the project, it really is awesome and I've been looking for something like this for quite a while already. :clap:

While extending the project to install the latest release of bat, I wanted to reuse the install functions provided, more specifically the install_remote_package option. To this end, I get the latest release from github using their API, but the download url I get from them makes a redirect which curl does not follow since only the -O flag is used.

Is there a particular reason why you did this way, or should we just add the -L flag to follow redirects?

dcupif avatar Sep 03 '19 21:09 dcupif

I have no reason for this, if you have a better way do open a PR. :)

snwh avatar Sep 06 '19 15:09 snwh

Done, I checked for others occurrences of curl, but I think it only makes sense to change it for the generic install functions. Let me know what you think. I also made the download display silent, though it will still print errors if any.

dcupif avatar Sep 09 '19 20:09 dcupif