suru-icon-theme icon indicating copy to clipboard operation
suru-icon-theme copied to clipboard

Missing icon: gnome-aisleriot

Open ubuntujaggers opened this issue 6 years ago • 6 comments

Hi @snwh,

gnome-aisleriot doesn't yet have a Suru icon:

image

I can fork here and submit a PR for my attempt if you're amenable to reviewing:

gnome-aisleriot svg

?

ubuntujaggers avatar Sep 28 '18 07:09 ubuntujaggers

Of course I'm amenable, I've always been open to PRs where I can review proposed icons (one at at time).

I like the direction of this icon you have, but the A❤️ on the largest icon would need to be positioned better within the bounding grid (press \ in Inkscape to show it, iirc) Alternatively, I'd try something along the lines of either:

  1. have "physical" cards as separate objects from the background as part of the pictogram
  2. or have "layers" like the calculator app icon and the lower layer be a card background

snwh avatar Oct 03 '18 18:10 snwh

Brilliant, I'll work further on this and Mahjongg.

ubuntujaggers avatar Oct 04 '18 18:10 ubuntujaggers

This is a version of the largest with some refined positioning:

gnome-aisleriot pixel grid svg

The "A" and the heart are positioned as follows:

  • Vertically centred relative to the whole squircle;
  • Horizontally centred within the left half of the squircle (so equidistant between the left edge of the squircle and its centre point);
  • The distances from the edges (including the icon centre as the right "edge") are all 24px which is a multiple of 4px.
  • The heart and the "A" are both 72x72px, again a multiple of 4px.

ubuntujaggers avatar Oct 04 '18 19:10 ubuntujaggers

That's largely the same positioning. It's too large and too close to the edges of the shape so proportionally it is off.

snwh avatar Oct 11 '18 17:10 snwh

aisleriot smaller

Hotter, colder?

EDIT: When the position/proportion is right I'll make sure the nodes of the pictogram are at exact pixels.

ubuntujaggers avatar Oct 11 '18 18:10 ubuntujaggers

@ubuntujaggers the pictogram should have a slight shadow as seen in the next icon gnome-software

jnlucian avatar Oct 22 '18 18:10 jnlucian