suru-icon-theme icon indicating copy to clipboard operation
suru-icon-theme copied to clipboard

Missing icon: gnome-mahjongg

Open ubuntujaggers opened this issue 6 years ago • 8 comments

Hi @snwh,

gnome-mahjongg doesn't yet have a Suru icon:

image

I can fork here and submit a PR for my attempt if you're amenable to reviewing:

mahjongg fully suru

?

ubuntujaggers avatar Sep 28 '18 07:09 ubuntujaggers

This is a great start, but the mahjongg tile is a bit too rounded on the largest icon. I also think preserving the yellow from the original icon in some way would be a good idea, such as in the background or possibly colouring the character on the tile yellow.

snwh avatar Oct 03 '18 18:10 snwh

Let me take another pass at it. The characters in Mahjongg have meaningful colours, so recolouring this particular one might be like doing spades or clubs in red on a playing card. I'll look at the Wikipedia page and see what characters/colours are available.

ubuntujaggers avatar Oct 04 '18 18:10 ubuntujaggers

Less rounded:

gnome-mahjongg svg less rounded

In terms of the yellow, all the standard characters seem to be red, green and blue, which is honoured in the Gnome version of the game. I've tried yellow background/blue character but it looks a bit naff so far. I'll see what inspiration I can find on Google Images...

ubuntujaggers avatar Oct 04 '18 19:10 ubuntujaggers

@ubuntujaggers What do you think of these tonalities for your icon?

46496653-7e5f3200-c810-11e8-965e-094dcee5ed19 I think the idea of ​​sam with the icons is that although he finds freedom to bifurcate gnome icons, he uses his colors to represent his identity in the form of suru

jnlucian avatar Oct 16 '18 05:10 jnlucian

I like the colours; the only difficulty is that the character is blue in Mahjongg, so this is like doing the Ace of Hearts with a black heart.

However, I guess we could pick one of the red characters and go with a similar colour scheme to the above? Salmon pink is close enough to red for the difference in shade to be artistic licence IMO.

ubuntujaggers avatar Oct 16 '18 19:10 ubuntujaggers

@jnlucian @snwh

What do you think of the following:

image

image

?

  • Keeps the yellow from the Gnome icon;
  • Character is a real Mahjong character ("Red Dragon");
  • Mahnong pictogram takes reasonable liberties with the colour (insofar as pink is just a pastel shade of red, which is the character's colour in the game).

EDIT: Alternate version with a little more detail on the glyph:

image

image

EDIT 2: I think the first (simpler) version looks better IMO.

ubuntujaggers avatar Oct 17 '18 10:10 ubuntujaggers

the colors makes it faithful to the original icon and I like the icon, just wait for the blessing of Sam and that of his opinion

jnlucian avatar Oct 18 '18 04:10 jnlucian

Okay, I've had a look at the "red dragon" character as it appears in most fonts, this is my final version unless I get any more requests:

final mahjongg

It has a little more detail than the simplest version, and the "fangs" (serifs?) that point down at the left and right seem to be common in fonts that include the character in a square, non-calligraphy style (e.g.: 中).

@snwh do you consider this one ready for a PR?

ubuntujaggers avatar Oct 18 '18 17:10 ubuntujaggers