cruise icon indicating copy to clipboard operation
cruise copied to clipboard

Usages of Logger.entering and Logger.exiting

Open jsjason opened this issue 9 years ago • 2 comments

The methods Logger.entering() and Logger.exiting() are in some classes, mostly for debugging purposes. REEF also has these methods in various classes, mainly the group communication classes. However, I do feel a bit doubtful about glittering methods with entering() and exiting(). If they're not very useful, we could just take them out instead of using up extra lines. I'd like to know how the others think.

jsjason avatar Aug 04 '15 06:08 jsjason

+1 to take them out. I've observed that the log entries are not easy to parse. Any other thoughts?

yunseong avatar Oct 24 '16 04:10 yunseong

We might as well and create a PR for this one. Though, we should make sure that taking out all instances of LOG.entering/exiting truly doesn't matter for any of us.

jsjason avatar Oct 24 '16 19:10 jsjason