fungus
fungus copied to clipboard
Character Editor Additional Workflow & UI Refresh
Description
Adding new functionality to CharacterEditor, such as:
- Navigating or doing portrait preview.
- Removing single portrait
- Clearing portrait list
- Bulk dropping files into drag and drop area provided in the inspector.
- Locking/Unlocking Character inspector tab so user can easily selecting multiple files without losing focus.
What is the current behavior?
- We can't easily add multiple files to character's portrait due to inspector focus issue
- The slots in inspector for adding character portraits are way too small and easily be missed.
- Character previewer only preview/show the very first portrait in portrait list.
- Deleting individual file is a chore and very easy to miss.
- Adding multiple files one-by-one are prone to error (I did this a lot and it's sickening)
What is the new behavior?
New UIs added:
Navigating between portrait/portrait preview https://user-images.githubusercontent.com/64100867/122751104-878ed680-d2b9-11eb-9f82-8cf6bb921bf3.mp4
Removing Individual Portrait With Confirmation Box
https://user-images.githubusercontent.com/64100867/122751300-c9b81800-d2b9-11eb-8b01-7f4a0cac5c61.mp4
Clear Portrait List (Remove All) https://user-images.githubusercontent.com/64100867/122751457-f835f300-d2b9-11eb-9a39-85607a3cb272.mp4
Locking/Unlocking Inspector https://user-images.githubusercontent.com/64100867/122751518-0dab1d00-d2ba-11eb-8bc7-b7dfcfae9c0d.mp4
There's a provided dragNdrop area in the character inspector so we can just drop our files all at once into that spot. While doing so, the inspector can also be locked so it won't lose focus when selecting multiple files or when switching between folders.
Important Notes
- My change require modifcations or additions to documentation
- My change modifies the workflow/editing of Character inspector/editor etc.
Other information
Note: My knowledge about CustomEditor is very limited thus, if you think that this is not the correct implementation, please let me know.
Note2: I worked this pr outside my local github, so I had to manually cherry picked them, proly there are something is missing, so pls let me know if it's not working on your end.
I'm not very good with CustomEditor in general, and this pr is part of my journey to learn it, I'm open to any suggestions, if any @stevehalliwell
And if you can.. just a very simple/basic ones XD
I'm reluctant of using loops, instead I only used a counter to make the code much simpler as this is just an editor, in case you're wondering.
I can change that of course if desired. Thanks!
@breadnone
Thank you for your work.
I have a suggestion to change the style of the buttons to make it look like this.
mybuttonStyle.fixedHeight = 40;
mybuttonStyle.normal.textColor = new Color32(255, 255, 255, 255);
Otherwise, the text of the buttons is not readable without hovering over the button. I have changed the height of the buttons to make the last button look better.
.
Hi, thanks for testing this... Could you take a screenshot of it? As far as I remember about this pr, it would not produce such behavior
.
Hi, thanks for testing this... Could you take a screenshot of it? As far as I remember about this pr, it would not produce such behavior
Hello! This is what your version looks like
Changed the buttons color text
Changed the buttons height
Forgive me for my bad English, I used a translator :(
Seems you're using non standard setup? As you can see, the font in your screenshot changed to grey instead of black
Seems you're using non standard setup? As you can see, the font in your screenshot changed to grey instead of black
Unity LTS install from unity hub, mac os 11.15.7, I did not make any interface settings, as it was established, and I use them