fungus icon indicating copy to clipboard operation
fungus copied to clipboard

JSONChecker.cs uses deprecated code.

Open ianicmathieu opened this issue 3 years ago • 2 comments

Describe the bug Assets\Fungus\Thirdparty\FungusLua\Thirdparty\JSON\Editor\JSONChecker.cs(76,28): warning CS0618: 'UnityWebRequest.isNetworkError' is obsolete: 'UnityWebRequest.isNetworkError is deprecated. Use (UnityWebRequest.result == UnityWebRequest.Result.ConnectionError) instead.'

Not exactly sure why this is popping up in 2020 LTS but in my project, I have this warning.

Looks like some code needs to be updated.

ianicmathieu avatar Mar 29 '21 12:03 ianicmathieu

while (!test.isDone && test.result == UnityWebRequest.Result.ConnectionError); (edited)

The fix appear to be change the unitywebrequest line to this.

ianicmathieu avatar Mar 29 '21 12:03 ianicmathieu

Just from the file path, seems to come from a thirdparty dep. So we'll either check there for updates or consider bringing it out into our own fork, if the license allows.

stevehalliwell avatar May 01 '21 21:05 stevehalliwell