snoyer
snoyer
Regardless of which one(s) you decide to implement in `build123d` you may want to pick the names according to existing standards/conventions if possible, for example: https://en.wikipedia.org/wiki/DE-9IM#Spatial_predicates, or, as per [shapely](https://github.com/shapely/shapely/blob/main/shapely/predicates.py):...
> In Python, the `with .. ` construct doesn't follow Python scoping rules which causes a great deal of confusion when using them in functions like this. Can you elaborate...
@gumyr I'm not sure I understand all of the implications for every possible `build123d` usecase, but for the issue at hand, looking higher up the stack of frames to decide...
> This is how it works currently, see: [`dev`/src/build123d/build_common.py#L234](https://github.com/gumyr/build123d/blob/dev/src/build123d/build_common.py?rgh-link-date=2024-10-04T14%3A12%3A42Z#L234) However, improvements are welcome. yes that is the function I proposed a modification of. Instead of checking that `Builder._get_context()._python_frame` _is_ `inspect.currentframe()`...
I generated it with `three.js` as a minimal sample to hit the "too many bones" case and I did not check the validity at the time. I _might_ still have...
Would this be the right time to rename this argument to `--no-config` or something? `--dry-run` is [used in many CLI applications](https://www.google.com/search?q=%22--dry-run%22+site%3Alinux.die.net) to mean "run as normal but don't actually write/change...
specific case of `Shape.split( ... keep != Keep.BOTH)` raises `ValueError: Null TopoDS_Shape object`
there's a call to `tool.thicken(0.1)` in `split()` and https://github.com/gumyr/build123d/blob/c0728e08036369e34ca479f3139a5ea6f8abb308/src/build123d/topology.py#L8916-L8920 can fail without raising the expected `StdFail_NotDone` error. with the following patch, it will raise `RuntimeError: Error applying thicken to given...
@jdegenstein would transforming in-place save you a few milliseconds? ```py for i in range(1, reader.NbNodes() + 1): p = reader.Node(i) p.Transform(transformation) reader.SetNode(i, p) ```
> Any suggestion on how to isolate this to a build123d vs display problem? [F3D](http://f3d.app) can open both `.brep` and `.vtp` files so you could compare the OCCT dump and...
Looks like the cone itself is fine but there's something going on when exporting through VTK. For example, exporting to `.vtp` after changing the `n_filter.SetFeatureAngle(360)` line as mentioned in my...