http-client icon indicating copy to clipboard operation
http-client copied to clipboard

httpSink Sink Depricated

Open BebeSparkelSparkel opened this issue 4 years ago • 4 comments

https://hackage.haskell.org/package/conduit/docs/Data-Conduit.html#t:Sink

Deprecated: Use ConduitT directly

BebeSparkelSparkel avatar Aug 27 '19 13:08 BebeSparkelSparkel

Please clarify what this means

snoyberg avatar Aug 27 '19 16:08 snoyberg

httpSink uses Sink which is being deprecated

BebeSparkelSparkel avatar Aug 27 '19 16:08 BebeSparkelSparkel

No, it's name includes Sink. Unless I'm misreading everything, it does not use the deprecated identifier. Can you please look again?

snoyberg avatar Aug 27 '19 16:08 snoyberg

then httpSink docs should be updated http://hackage.haskell.org/package/http-conduit-2.3.7.1/docs/Network-HTTP-Simple.html#v:httpSink

BebeSparkelSparkel avatar Aug 27 '19 18:08 BebeSparkelSparkel