snowplow-rdb-loader icon indicating copy to clipboard operation
snowplow-rdb-loader copied to clipboard

RDB Loader: migrate to slf4j logging

Open chuwy opened this issue 4 years ago • 0 comments

Currently we use our own Logging algebra, which allows us to test logging and abstract it away, however it's very unflexible.

  1. It doesn't allow to disable logging for some classes at launch time
  2. It doesn't show where logging is coming from
  3. It doesn't allow to configure severity

log4cats gives us these abilities, but unfortunately has another downside - we need to either abandon F[_]: Logging signatures and instantiate one logger per class (and damage testing) or have Main class everywhere, which defeats 1st and 2nd points.

There's some WIP in log4cats I hope to get merged at some point (https://github.com/typelevel/log4cats/pull/421, https://github.com/typelevel/log4cats/issues/397). When the PR is merged we can migrate without trade-offs.

chuwy avatar Oct 16 '21 10:10 chuwy