snowplow-javascript-tracker icon indicating copy to clipboard operation
snowplow-javascript-tracker copied to clipboard

Fix youtube tracking typings

Open igneel64 opened this issue 2 years ago • 0 comments

Describe the bug The typings on the youtube browser tracking seem to be erroneous and not helpful for TypeScript users.

To Reproduce Just try adding a captureEvent option on enableYouTubeTracking.

E.g.

    enableYouTubeTracking({
      id: videoId,
      options: {
        captureEvents: ["error"],
      },
    });

Expected behavior Types work as expected without errors.

Screenshots image

Additional context Changes in this should can be accompanied with a revision of typings such as EventGroup in types.ts which can allow for proper autocompletion in TS (expected DX).

igneel64 avatar Oct 03 '22 14:10 igneel64