schema-guru icon indicating copy to clipboard operation
schema-guru copied to clipboard

Published 20 hours ago • verified publisher icon snowplow

Decide on strategy around requiredFields

Open alexanderdean opened this issue 9 years ago • 6 comments

Should we be adding all fields we see to requiredFields, and then removing them if they are not seen in another instance?

alexanderdean avatar Jun 02 '15 17:06 alexanderdean

Pushing back...

alexanderdean avatar Jul 03 '15 23:07 alexanderdean

I think we should be adding all fields we see to requiredFields - otherwise there is basically no way of creating a NOT NULL field in our schema...

alexanderdean avatar Aug 13 '15 23:08 alexanderdean

/cc @fblundun

alexanderdean avatar Aug 13 '15 23:08 alexanderdean

I think the only way is to add field to requiredFields if it occurring in ALL instances. If it's omitted even once it isn't required.

chuwy avatar Aug 14 '15 09:08 chuwy

Agreed

alexanderdean avatar Aug 14 '15 09:08 alexanderdean

That sounds sensible to me.

fblundun avatar Aug 14 '15 13:08 fblundun