Patch: com.getvero

[misterpig]

So the bug exists in the campaign.id field. Turns out the id field of this is an integer unlike the user.id field. Removing the type field wouldn't impact the adapter as the adapter removes the type field anyway; keeping type field in the schema is redundant as it'll contain NULL for every event after enrichment. Also increased the campaign.permalink field to accomodate long URLs.

[alexanderdean]

Thanks @misterpig !

[snowplowcla]

@misterpig has signed the Software Grant and Corporate Contributor License Agreement

[BenFradet]

@chuwy how should we proceed here? background is in #842

[chuwy]

Hey @BenFradet, @misterpig,

I still have the same opinion I left in #842:

• If any amount of data (5/8 as far as I can understand) got to DB, we cannot accept this as a patch because we'll need to migrate the table, otherwise it will just break loading process
• We can accept it as 2-0-0 without problems
• Commit history needs to follow ticket:commit 1:1 convention

[chuwy]

And also as I mentioned before, it seems we're using type property in SCE logic, so I'm not sure we can safely remove it.

[BenFradet]

ok thanks, leaving in the 101 milestone for now.

@misterpig if you could do the necessary changes, i.e. move to 2-0-0, we could integrate it into release 113.