iglu-central icon indicating copy to clipboard operation
iglu-central copied to clipboard

Wrong schema version in com.snowplowanalytics.snowplow.storage/postgresql_config

Open andrewhabib opened this issue 4 years ago • 2 comments

Hi again,

In com.snowplowanalytics.snowplow.storage/postgresql_config, there is a wrong increment of the schema version from 1-0-0 to 1-1-0 which does not respect the SchemaVer.

The change from version 1-0-0 to version 1-1-0 is fully backward compatible:

  • Existing password field is expanded from "type": "string" to "type": ["string", "object"]
  • Two new keys sshTunnel and id are added but additionalProperties was False

So nothing breaks backward compatibility and the proper new schema version should be 1-0-1, not 1-1-0

andrewhabib avatar Aug 11 '20 22:08 andrewhabib

Hi @andrewhabib ,

Thank you for reporting this.

id was added in 1-0-1, not in 1-1-0, but still you are right that there is no case where 1-0-1 data can not be validated with 1-1-0 schema, so it should have been 1-0-2 and not 1-1-0.

Unfortunately this is too late to fix it now, we can't delete 1-1-0 given that it might be used by people, even if latest version is 2-0-0.

benjben avatar Aug 13 '20 15:08 benjben

Re-opening as per https://github.com/snowplow/iglu-central/issues/1072#issuecomment-674085232

chuwy avatar Aug 14 '20 13:08 chuwy