data-models icon indicating copy to clipboard operation
data-models copied to clipboard

BigQuery Web: Rename min_tstamp in sessions_userid_manifest_this_run

Open bill-warner opened this issue 4 years ago • 3 comments

Inconsistent naming of the tstamp between sessions_userid_manifest_staged and sessions_userid_manifest_this_run.

Suggest we change min_tstamp to start_tstamp here to align with other web models.

bill-warner avatar Apr 20 '21 12:04 bill-warner

It's min_tstamp in Redshift too https://github.com/snowplow/data-models/blob/e1e10fb696a52aa9bc990e975154405779f421de/web/v1/redshift/sql-runner/sql/standard/03-sessions/01-main/05-sessions-prep-manifest.sql#L27

I'm on board with changing the name to whatever. I think I went with min_tstamp as it represents the first timestamp found for a given domain_userid, rather than the start of a session/page view. In my head, the thought process was that if we want it to be called start_tstamp, it should be first_start_tstamp.

Having said that, it's all entirely academic, so whatever we wanna name it I won't argue - I agree that it should have the same name across all 3 though. :)

colmsnowplow avatar Apr 20 '21 12:04 colmsnowplow

All fair points. I think given a) we use start_tstamp within the users module to denote the first time a user is active and b) the sessions_userid_manifest_staged table, which we insert the data into, uses start_tstamp across all 3 models already it makes most sense to rename to start_tstamp

bill-warner avatar Apr 20 '21 12:04 bill-warner

Fair, I'm on board.

colmsnowplow avatar Apr 20 '21 12:04 colmsnowplow