Alan D. Snow

Results 441 comments of Alan D. Snow

> Possible bug in rioxarray, should the second dim be .y_dim? Definitely a bug - thanks for pointing that one out.

> If the DataArray has a valid grid_mapping (not an empty string) why shouldn't we assume that it is a spatially-based variable? For a `DataArray`, it behaves as you mentioned....

> In some of my data cases I definitely have 1D variables that could/should have an associated grid mapping/CRS so they would probably fail this check in rioxarray anyway. Yes,...

> GDAL support only OGC WKT GEOGCS and PROJCS Projections (in crs_wkt) GDAL 3+ uses PROJ for reading and writing CRS WKT. So, it supports the WKT output from pyproj...

Two things to consider: 1. For rioxarray, only the 1D coordinates are supported & the 2D are ignored. 2. When writing, compatibility with GDAL/ArcGIS should be considered. I don't think...

Thanks for making the prototype. That looks pretty nice. Do you think it would be better to wait before officially adding it to rioxarray so some wrinkles can be ironed...

Sounds like a good plan to me. Anyone who would like to try implementing the CRSIndex and adding it to `rio.write_crs` is welcome to, If you do get started, please...

Nice :+1: My first thought is to make `use_crs_index=True/False` a global option [ref](https://github.com/corteva/rioxarray/blob/master/rioxarray/_options.py). Another idea was to add a `crs_index_error=True/False` global option to raise an exception if enabled and the...

> Could this screw up a downstream package though? It works as a context manager and so it can be applied locally as well. Though, the current strategy would work...

> It may be prudent to be strict now and loosen things later. Since it is optionally enabled (and off by default), being strict is fine.