selective icon indicating copy to clipboard operation
selective copied to clipboard

Published 20 hours ago • verified publisher icon snowleopard

Dev maybe t

Open turion opened this issue 2 years ago • 13 comments

See https://github.com/snowleopard/selective/pull/39#issuecomment-1164093318 and https://github.com/snowleopard/selective/issues/37#issuecomment-1162756271

turion avatar Jun 23 '22 09:06 turion

Ah, the whole deriving via story doesn't work on older GHCs. Which makes this refactoring a bit pointless. If it's fine for you I'll leave this PR hanging round until maybe one day those older versions are dropped.

turion avatar Jun 23 '22 13:06 turion

Hmm, unlocking DerivingVia seems like a pretty solid reason to drop support for older GHCs.

@vrom911 I can see that validation-selective currently supports GHC 8.4. How sad will you be if selective stops supporting it?

snowleopard avatar Jun 23 '22 17:06 snowleopard

I went ahead and dropped support for older GHC versions, so we can now use DerivingVia!

Would you like to finish this PR? Happy to do this myself since I made some changes that might make rebasing this a bit tedious.

snowleopard avatar Feb 19 '23 06:02 snowleopard

Feel free to do it yourself, I can't come back to it in the next few weeks.

turion avatar Feb 20 '23 11:02 turion

@snowleopard I can probably make that kind of call regarding validation-selective in the future, since @tomjaguarpaw and I are maintainers for the lib now. :)

Kleidukos avatar Jan 25 '24 08:01 Kleidukos

@Kleidukos Cool, thanks :) What's the last version of GHC that you support?

snowleopard avatar Mar 02 '24 21:03 snowleopard

9.8

tomjaguarpaw avatar Mar 02 '24 21:03 tomjaguarpaw

9.8

@tomjaguarpaw Oops, sorry, I meant to ask about the oldest supported version.

snowleopard avatar Mar 02 '24 21:03 snowleopard

8.6, as confirmed by our test suite: https://github.com/kowainik/validation-selective/blob/a99a6610958090e55fa48ab936736471f1589691/.github/workflows/ci.yml#L24.

tomjaguarpaw avatar Mar 02 '24 21:03 tomjaguarpaw

Got it, thanks! With #78 landing, selective supports the same version range, though I wonder if I should drop a few older versions. It's unclear if it's worth supporting so many versions.

snowleopard avatar Mar 02 '24 21:03 snowleopard

What's the cost to supporting them?

tomjaguarpaw avatar Mar 02 '24 21:03 tomjaguarpaw

What's the cost to supporting them?

CPP noise, CI time, and even just needing to think about them.

snowleopard avatar Mar 02 '24 22:03 snowleopard

Yeah, it's hard to know whether the cost is worth paying without knowing how many people are continuing to use the package on older versions.

tomjaguarpaw avatar Mar 04 '24 19:03 tomjaguarpaw