snowpark-python icon indicating copy to clipboard operation
snowpark-python copied to clipboard
verified publisher icon snowflakedb

Add type to expression when there is ignore nulls and offset != 0

Open frederiksteiner opened this issue 1 year ago • 1 comments

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1526571

https://github.com/snowflakedb/snowpark-python/issues/1887

  1. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
      • [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
    • [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  2. Please describe how your code solves the related issue.

    Previously, when using lead and lag on the specified table, they returned a NullType column in local testing. Now it should return the proper type.

frederiksteiner avatar Jul 09 '24 11:07 frederiksteiner

Thanks for the PR. Do you have an example for when you observed the errant behavior that this PR fixes?

sfc-gh-jrose avatar Jul 09 '24 16:07 sfc-gh-jrose

There should be an example in the issue that I linked: https://snowflakecomputing.atlassian.net/browse/SNOW-1526571

frederiksteiner avatar Jul 09 '24 20:07 frederiksteiner

Commits added to this PR #1959 and merged

frederiksteiner avatar Jul 30 '24 07:07 frederiksteiner