snowpark-python icon indicating copy to clipboard operation
snowpark-python copied to clipboard

SNOW-1060154: Add telemetry for query plan height and num duplicate subtrees

Open sfc-gh-aalam opened this issue 11 months ago • 4 comments

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1060154

  2. Fill out the following pre-review checklist:

    • [x] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [x] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This PR add plan_height and num_duplicate_nodes in SnowflakePlan and Selectable class to compute characteristics of the query plan tree and report these in telemetry

sfc-gh-aalam avatar Mar 12 '24 01:03 sfc-gh-aalam

I assume it will be rebased after #1295 being merged?

sfc-gh-jdu avatar Mar 13 '24 19:03 sfc-gh-jdu

I assume it will be rebased after #1295 being merged?

yes

sfc-gh-aalam avatar Mar 13 '24 20:03 sfc-gh-aalam

Let's get Yijun's approval before merging

sfc-gh-jdu avatar Mar 26 '24 18:03 sfc-gh-jdu

Client performance when running union api when 50 columns and varying n calls: Screenshot 2024-04-09 at 10 40 40 PM

sfc-gh-aalam avatar Apr 09 '24 17:04 sfc-gh-aalam