snowpark-python
snowpark-python copied to clipboard
[Mypy] Add dataframe.py to mypy coverage
Please answer these questions before submitting your pull requests. Thanks!
-
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
-
Fill out the following pre-review checklist:
- [ ] I am adding a new automated test(s) to verify correctness of my new code
- [ ] I am adding new logging messages
- [ ] I am adding a new telemetry message
- [ ] I am adding new credentials
- [ ] I am adding a new dependency
-
Please describe how your code solves the related issue.
There are a lot of places in this file where attributes or variables are passed that don't have strong typing so I've added quite a few exceptions. In the future it might be useful to refactor some of our code to use Protocols instead of Unions of various types. Propagating the unions through all functions gets very complex, this is especially true for things like SelectStatement
vs MockSelectStatement
or Expression
vs NamedExpression
.