snowpark-python icon indicating copy to clipboard operation
snowpark-python copied to clipboard

Update StringType repr

Open sfc-gh-yixie opened this issue 1 year ago • 2 comments

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-yixie avatar Nov 05 '23 04:11 sfc-gh-yixie

@sfc-gh-aalam I'm very confused why this test failed from this change. It looks irrelevant to StringType. FAILED tests/integ/test_udf.py::test_udf_timestamp_type_hint

sfc-gh-yixie avatar Nov 07 '23 04:11 sfc-gh-yixie

Do we not have a JIRA associated with this? If yes, please attach to the PR title. If not, please be more descriptive on why we want to make this change in the PR description.

I'm also curious as to why we need this change. Is this going to a BCR?

sfc-gh-stan avatar Nov 07 '23 18:11 sfc-gh-stan