snowflake-sqlalchemy icon indicating copy to clipboard operation
snowflake-sqlalchemy copied to clipboard

Published 20 hours ago • verified publisher icon snowflakedb

Snow 1058245 SqlAlchemy 2.0 support

Open sfc-gh-mraba opened this issue 4 months ago • 2 comments

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1058245

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
    • [x] I am adding compatibility with SQLAlchemy 2.0

  3. Please describe how your code solves the related issue.

We adapted SnowflakeDialect compatibility with SQLAlchemy 2.0. We added testing jobs with SQLAlchemy 2.0 installed. We moved from tox to hatch.

sfc-gh-mraba avatar Feb 16 '24 13:02 sfc-gh-mraba

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Mar 01 '24 14:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

sfc-gh-astus avatar Mar 04 '24 12:03 sfc-gh-astus

🚀

antonrh avatar Apr 12 '24 14:04 antonrh

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

nitin-kakkar avatar Apr 18 '24 20:04 nitin-kakkar

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

Would really appreciate if you could provide some timeline. Thanks!!

nitin-kakkar avatar Apr 19 '24 16:04 nitin-kakkar

It looks like implementation is completed and pull request is also approved. Any timelines for merging it and releasing ne version of snowflake-sqlalchemy?

satniks avatar Apr 19 '24 17:04 satniks

fwiw, I've been running this code in production for a few days and had no issues

sjhewitt avatar Apr 19 '24 18:04 sjhewitt

hey folks thank you for the interest; please head to the pinned issue https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

@sjhewitt appreciate your comment very much, good to hear the changes are running without major issues !

sfc-gh-dszmolka avatar Apr 20 '24 07:04 sfc-gh-dszmolka

@sfc-gh-mraba - Is there any update on timelines for merging and releasing new version of snowflake-sqlalchemy?

nitin-kakkar avatar May 01 '24 21:05 nitin-kakkar

@nitin-kakkar please head to the pinned issue https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

sfc-gh-dszmolka avatar May 02 '24 04:05 sfc-gh-dszmolka