snowflake-sqlalchemy icon indicating copy to clipboard operation
snowflake-sqlalchemy copied to clipboard

Published 20 hours ago • verified publisher icon snowflakedb

Fix sub-processing of ‘MERGE INTO’

Open luciengaitskell opened this issue 3 years ago • 4 comments

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #322

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Fix sub-processing of MERGE INTO compiler.

luciengaitskell avatar Jul 20 '22 16:07 luciengaitskell

Hi @luciengaitskell it looks like you missed this part of the issue template:

Make sure that there is an accompanying issue to your PR.

Please create an issue and describe the problem itself before fixing it

Thanks!

sfc-gh-mkeller avatar Jul 20 '22 18:07 sfc-gh-mkeller

Please create an issue and describe the problem itself before fixing it

I have now created issue #322

luciengaitskell avatar Jul 21 '22 09:07 luciengaitskell

@sfc-gh-mkeller Am I missing any remaining steps for the review process? Thanks in advance.

luciengaitskell avatar Jul 26 '22 13:07 luciengaitskell

Just to bump this- Is there a chance of having this PR reviewed?

luciengaitskell avatar Oct 12 '22 15:10 luciengaitskell