snowflake-kafka-connector icon indicating copy to clipboard operation
snowflake-kafka-connector copied to clipboard

Use .equals() to compare schemas

Open cchandurkar opened this issue 1 year ago • 5 comments

If SMT clones the schema of the object for any reason, it does not have the same "hash" as original schema but structurally it's the same. Using !.equals() instead of != will allow SMTs to properly clone the schemas.

cchandurkar avatar Sep 26 '23 20:09 cchandurkar

lgtm!

Have you previously signed CLA? If not, mind sending an email address where Snwoflake can send a CLA document to push PRs on public repos? Thanks

I have not, you can send it on: [email protected]

cchandurkar avatar Sep 28 '23 14:09 cchandurkar

Thanks for signing the CLA. This is good to merge. @sfc-gh-japatel @sfc-gh-rcheng

sfc-gh-xhuang avatar Oct 18 '23 22:10 sfc-gh-xhuang

@sfc-gh-japatel any thoughts on this? I've seen this issue popping up a multiple times where a schema closed in SMT doesn't have the same hash as original schema and this equality check fails even when the schema is structurally identical. Using .equals() fixes it.

cchandurkar avatar Nov 06 '23 19:11 cchandurkar

@sfc-gh-mbobowski and team to also help review any implications.

sfc-gh-xhuang avatar Jan 19 '24 18:01 sfc-gh-xhuang