snowflake-jdbc icon indicating copy to clipboard operation
snowflake-jdbc copied to clipboard

NO-SNOW: Remove usage of session for sessionless client telemetry

Open sfc-gh-tzhang opened this issue 2 years ago • 1 comments

Overview

NO-SNOW

https://github.com/snowflakedb/snowflake-jdbc/pull/715 added a change to use authTimeout and socketTimeout as part of the HttpUtil.executeGeneralRequest function, but for sessionless client telemetry, the session is null, so we need to use the default value instead of getting it from the session object.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modyfying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modyfying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • [ ] This change has passed precommit
  • [ ] I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-tzhang avatar Apr 22 '22 22:04 sfc-gh-tzhang

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubemergegate[bot] avatar Apr 23 '22 01:04 sonarqubemergegate[bot]

@sfc-gh-hchaturvedi @sfc-gh-mknister Can I get a review on one of the required reviewers? Thanks!

sfc-gh-tzhang avatar Sep 08 '22 19:09 sfc-gh-tzhang