snowflake-jdbc icon indicating copy to clipboard operation
snowflake-jdbc copied to clipboard

SNOW-466174: Add stacktrace to sfformater

Open sfc-gh-wshangguan opened this issue 3 years ago • 1 comments

Overview

SNOW-466174 Currently the SFFormatter doesn't print out stack trace of an exception in logger. However, this is inconvenient for us to debug RT because the SFFormatter-JDK14Logger is used in RT. So this pr is to print stack trace when an exception iteself is passed into logger as an argument.

CASEC: https://github.com/snowflakedb/security_reviews/pull/1066

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modyfying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modyfying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • [ ] This change has passed precommit
  • [ ] I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-wshangguan avatar Sep 20 '21 23:09 sfc-gh-wshangguan

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubemergegate[bot] avatar Oct 06 '21 18:10 sonarqubemergegate[bot]

Checked with Wufan, it's ok to close this old PR.

sfc-gh-igarish avatar Oct 20 '22 18:10 sfc-gh-igarish