snowflake-jdbc icon indicating copy to clipboard operation
snowflake-jdbc copied to clipboard

SNOW-680583 make JDBC compatible with stored proc JDBC

Open sfc-gh-zli opened this issue 2 years ago • 4 comments

Overview

SNOW-680583 make JDBC compatible with stored proc JDBC

server side change: https://github.com/snowflakedb/snowflake/pull/74768

The actual changes are here: https://github.com/snowflakedb/snowflake-jdbc/pull/1162/commits/f5ff1408ea3d63f7d85eecff9077b7e7283441d7 which simply removes getHttpClientConnectionTimeout and getHttpClientSocketTimeout from SFBaseSession.

All other changes belong to the revert PR.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modyfying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modyfying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • [ ] This change has passed precommit
  • [ ] I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-zli avatar Oct 19 '22 21:10 sfc-gh-zli

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Oct 19 '22 21:10 github-actions[bot]

@sfc-gh-zli Could you write a brief summary list of the structural changes you made in this PR? That will help make reviewing this easier. Thanks!

sfc-gh-ema avatar Oct 19 '22 22:10 sfc-gh-ema

@sfc-gh-zli Could you write a brief summary list of the structural changes you made in this PR? That will help make reviewing this easier. Thanks!

Updated the description

sfc-gh-zli avatar Oct 19 '22 22:10 sfc-gh-zli

Could you please add test case?

sfc-gh-igarish avatar Oct 25 '22 20:10 sfc-gh-igarish

Could you please add test case?

Changes in this PR will be covered by the tests added in this PR: #715 . So there is no need to add more tests.

sfc-gh-zli avatar Oct 27 '22 23:10 sfc-gh-zli

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubemergegate[bot] avatar Oct 28 '22 18:10 sonarqubemergegate[bot]