snowflake-jdbc icon indicating copy to clipboard operation
snowflake-jdbc copied to clipboard

SNOW-667402:Semgrep workflow update

Open sfc-gh-hpathak opened this issue 2 years ago • 7 comments

Overview

SNOW-667402 This PR removes legacy semgrep workflows for a reusable workflow. Local semgrep rules have been deleted. If your repo had a semgrep stage in the Jenkinsfile, we attempted to delete it. Please review changes and merge them as soon as possible. Announcement

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modyfying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modyfying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • [ ] This change has passed precommit
  • [ ] I have reviewed code coverage report for my PR in (Sonarqube)

sfc-gh-hpathak avatar Sep 29 '22 03:09 sfc-gh-hpathak

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Sep 29 '22 03:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

sfc-gh-hpathak avatar Sep 29 '22 03:09 sfc-gh-hpathak

@sfc-gh-mknister Could you please approve this? I dont have access to add reviewers

sfc-gh-hpathak avatar Sep 30 '22 03:09 sfc-gh-hpathak

@sfc-gh-igarish could you please approve and merge this? failures arent due to this change.

sfc-gh-hpathak avatar Oct 05 '22 03:10 sfc-gh-hpathak

You can merge once this check complete: Semgrep Expected — Waiting for status to be reported

sfc-gh-igarish avatar Oct 05 '22 23:10 sfc-gh-igarish

@sfc-gh-igarish Yes, but that one is stuck due some issue in GH. Im updating that check so for some reason it isnt running. Do you have admin on the repo? If so could you disable that check ?

sfc-gh-hpathak avatar Oct 05 '22 23:10 sfc-gh-hpathak

Could you please talk with Harsh Chaturvedi?

sfc-gh-igarish avatar Oct 05 '22 23:10 sfc-gh-igarish

@sfc-gh-hpathak I think you're trying to cherrypick your changes from your repo? Can you create a PR on snowflake-jdbc master instead? There are just merge conflicts that you can resolve in your PR.

sfc-gh-hchaturvedi avatar Nov 08 '22 01:11 sfc-gh-hchaturvedi

@sfc-gh-hchaturvedi will do. I didnt have write access to the repo earlier to create a branch directly. Seems like i do now. Will close this and merge the other branch

sfc-gh-hpathak avatar Nov 08 '22 01:11 sfc-gh-hpathak