snowflake-connector-python
snowflake-connector-python copied to clipboard
Change C++ Header Import Error to Clear Linter Warnings
-
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #888
-
Fill out the following pre-review checklist:
- [ ] I am adding a new automated test(s) to verify correctness of my new code
- [ ] I am adding new logging messages
- [ ] I am modifying authorization mechanisms
- [ ] I am adding new credentials
- [ ] I am modifying OCSP code
- [ ] I am adding a new dependency
-
Please describe how your code solves the related issue.
This PR modifies the header import order so that system includes always come before custom or library level orders.
@chuckthesoftwarechef could you also add cpplint
as part of this PR?
I've moved this PR over to draft status while I try to do that @sfc-gh-mkeller.
Hey @chuckthesoftwarechef we'll be following up with you with a CLA agreement which would need to be signed before we can merge your request. Please stay tuned. Thanks for your patience!
CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request