snowflake-connector-python icon indicating copy to clipboard operation
snowflake-connector-python copied to clipboard

Change C++ Header Import Error to Clear Linter Warnings

Open chuckthesoftwarechef opened this issue 3 years ago • 4 comments

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #888

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

This PR modifies the header import order so that system includes always come before custom or library level orders.

chuckthesoftwarechef avatar Oct 05 '21 13:10 chuckthesoftwarechef

@chuckthesoftwarechef could you also add cpplint as part of this PR?

sfc-gh-mkeller avatar Oct 05 '21 17:10 sfc-gh-mkeller

I've moved this PR over to draft status while I try to do that @sfc-gh-mkeller.

chuckthesoftwarechef avatar Oct 11 '21 16:10 chuckthesoftwarechef

Hey @chuckthesoftwarechef we'll be following up with you with a CLA agreement which would need to be signed before we can merge your request. Please stay tuned. Thanks for your patience!

sfc-gh-hchaturvedi avatar Oct 28 '21 21:10 sfc-gh-hchaturvedi

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Jul 20 '22 19:07 github-actions[bot]