snowflake-connector-python
snowflake-connector-python copied to clipboard
SNOW-630142 Custom Auth
Description Implemented custom auth and refactored the current auth methods to use the new custom auth class
Testing
Please answer these questions before submitting your pull requests. Thanks!
-
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-630142
-
Fill out the following pre-review checklist:
- [ ] I am adding a new automated test(s) to verify correctness of my new code
- [ ] I am adding new logging messages
- [ ] I am modifying authorization mechanisms
- [ ] I am adding new credentials
- [ ] I am modifying OCSP code
- [ ] I am adding a new dependency
-
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Just using GitHub to run some tests for me
Codecov Report
Merging #1215 (0ea7365) into main (253b2ce) will decrease coverage by
0.25%
. The diff coverage is83.06%
.
@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 81.70% 81.45% -0.26%
==========================================
Files 59 62 +3
Lines 8331 8650 +319
Branches 1353 1282 -71
==========================================
+ Hits 6807 7046 +239
- Misses 1224 1293 +69
- Partials 300 311 +11
Impacted Files | Coverage Δ | |
---|---|---|
src/snowflake/connector/network.py | 78.87% <0.00%> (-2.31%) |
:arrow_down: |
src/snowflake/connector/auth_keypair.py | 78.57% <60.00%> (-0.70%) |
:arrow_down: |
src/snowflake/connector/reauth_webbrowser.py | 62.50% <62.50%> (ø) |
|
src/snowflake/connector/auth_idtoken.py | 93.75% <66.66%> (-6.25%) |
:arrow_down: |
src/snowflake/connector/reauth_by_plugin.py | 70.00% <70.00%> (ø) |
|
src/snowflake/connector/connection.py | 89.22% <79.41%> (-1.29%) |
:arrow_down: |
src/snowflake/connector/reauth_default.py | 80.00% <80.00%> (ø) |
|
src/snowflake/connector/auth_by_plugin.py | 93.33% <93.33%> (-0.55%) |
:arrow_down: |
src/snowflake/connector/auth.py | 80.62% <100.00%> (+0.82%) |
:arrow_up: |
src/snowflake/connector/auth_default.py | 93.33% <100.00%> (+1.02%) |
:arrow_up: |
... and 17 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I think we need to align the implementation signature with the protocol, which should all just be keyword arguments