snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

SNOW-824882 SSO token cache

Open sfc-gh-ext-simba-jy opened this issue 10 months ago • 1 comments

Description

Please explain the changes you made here.

  • [x] Added id_token authentication
  • [x] Added secureStorage feature
  • [x] Added reauthentication

Checklist

  • [x] Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • [x] Create tests which fail without the change (if possible)
  • [x] Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • [x] Extend the README / documentation and ensure is properly displayed (if necessary)
  • [x] Provide JIRA issue id (if possible) or GitHub issue id in commit message

sfc-gh-ext-simba-jy avatar Apr 03 '24 17:04 sfc-gh-ext-simba-jy

Codecov Report

Attention: Patch coverage is 78.80795% with 32 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (03d557d) to head (8ca1118).

Files Patch % Lines
...tication/secure_storage/json_credential_manager.js 87.27% 7 Missing :warning:
lib/services/sf.js 50.00% 7 Missing :warning:
lib/connection/connection_config.js 68.75% 5 Missing :warning:
lib/util.js 78.26% 5 Missing :warning:
lib/connection/connection.js 60.00% 4 Missing :warning:
lib/authentication/auth_idtoken.js 72.72% 3 Missing :warning:
lib/core.js 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   89.20%   88.95%   -0.26%     
==========================================
  Files          62       64       +2     
  Lines        5947     6091     +144     
==========================================
+ Hits         5305     5418     +113     
- Misses        642      673      +31     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 18:04 codecov[bot]

@sfc-gh-ext-simba-jy please update branch with rebase and update security validation links in prepared in doc as well.

sfc-gh-pmotacki avatar Jun 17 '24 05:06 sfc-gh-pmotacki

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11748687 Triggered Generic High Entropy Secret 4d9b3d4c2e8ba246848fd8f32c0a4622841d44e7 test/unit/file_transfer_agent/encrypt_util_test.js View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jun 19 '24 18:06 gitguardian[bot]