snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

SNOW-979109: Support directories with GET and PUT of stages - NODE.JS

Open sfc-gh-ext-simba-jy opened this issue 1 year ago • 1 comments

Description

Please explain the changes you made here.

  • [x] Added ** which includes the subdirectory for Put command.
  • [x] Added a testing code for the new feature.

Checklist

  • [x] Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • [x] Create tests which fail without the change (if possible)
  • [x] Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • [x] Extend the README / documentation and ensure is properly displayed (if necessary)
  • [x] Provide JIRA issue id (if possible) or GitHub issue id in commit message

sfc-gh-ext-simba-jy avatar Dec 20 '23 07:12 sfc-gh-ext-simba-jy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7207966) 89.95% compared to head (56fdff0) 88.66%.

:exclamation: Current head 56fdff0 differs from pull request most recent head 0d78d81. Consider uploading reports for the commit 0d78d81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   89.95%   88.66%   -1.30%     
==========================================
  Files          59       61       +2     
  Lines        5615     5706      +91     
==========================================
+ Hits         5051     5059       +8     
- Misses        564      647      +83     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 20 '23 08:12 codecov[bot]