snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

SNOW-824882: MFA token caching to the node.js driver

Open sfc-gh-ext-simba-jy opened this issue 1 year ago • 1 comments

Description

  • [x] Added mfa token auth featuer
  • [x] Saved the mfa token in the secure storage.

Checklist

  • [ ] Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • [ ] Create tests which fail without the change (if possible)
  • [ ] Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • [ ] Extend the README / documentation and ensure is properly displayed (if necessary)
  • [ ] Provide JIRA issue id (if possible) or GitHub issue id in commit message

sfc-gh-ext-simba-jy avatar Nov 28 '23 18:11 sfc-gh-ext-simba-jy

Codecov Report

Attention: Patch coverage is 53.84615% with 24 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (2459e1c) to head (287ef84).

Files Patch % Lines
lib/util.js 20.00% 12 Missing :warning:
lib/connection/connection.js 33.33% 4 Missing :warning:
lib/authentication/authentication.js 40.00% 3 Missing :warning:
lib/authentication/auth_mfatoken.js 81.81% 2 Missing :warning:
lib/services/sf.js 60.00% 2 Missing :warning:
lib/connection/connection_config.js 83.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   88.93%   88.66%   -0.27%     
==========================================
  Files          64       65       +1     
  Lines        6109     6160      +51     
==========================================
+ Hits         5433     5462      +29     
- Misses        676      698      +22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 18:11 codecov[bot]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Jun 19 '24 21:06 gitguardian[bot]