snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

SNOW-824882 Id token cache

Open sfc-gh-ext-simba-jy opened this issue 1 year ago • 2 comments

Description

Please explain the changes you made here.

  • [x] Added id_token authentication
  • [x] Added secureStorage feature
  • [x] Added reauthentication

Checklist

  • [ ] Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • [ ] Create tests which fail without the change (if possible)
  • [ ] Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • [ ] Extend the README / documentation and ensure is properly displayed (if necessary)
  • [ ] Provide JIRA issue id (if possible) or GitHub issue id in commit message

sfc-gh-ext-simba-jy avatar Oct 10 '23 06:10 sfc-gh-ext-simba-jy

Codecov Report

Attention: Patch coverage is 75.32468% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 88.65%. Comparing base (42acd1d) to head (1911510).

Files Patch % Lines
...tication/secure_storage/json_credential_manager.js 76.38% 17 Missing :warning:
lib/services/sf.js 41.17% 10 Missing :warning:
lib/authentication/auth_idtoken.js 69.23% 4 Missing :warning:
lib/authentication/authentication.js 25.00% 3 Missing :warning:
lib/connection/connection.js 71.42% 2 Missing :warning:
lib/connection/connection_config.js 83.33% 1 Missing :warning:
lib/core.js 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   89.14%   88.65%   -0.50%     
==========================================
  Files          61       63       +2     
  Lines        5880     6029     +149     
==========================================
+ Hits         5242     5345     +103     
- Misses        638      684      +46     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 24 '23 08:11 codecov[bot]

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Snowflake Credentials 3c1be02bdbedd0a6a891a0caf5cb2662c972af6a testing.js View secret
- Snowflake Credentials 8e3b01cc757b270a402e1e54d66aacbfa46db649 testing.js View secret
8768007 Triggered Generic Password c082ca3d4df703120075d986335e4e34637d525b lib/http/base.js View secret
8768007 Triggered Generic Password 40286c3256c248dd636b775dd90a3035b13b2f96 lib/http/base.js View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn’t add this secret (and only then), you can skip this check manually.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 28 '24 00:03 gitguardian[bot]

This PR has been open for a long time with many comments, so I made a new PR : https://github.com/snowflakedb/snowflake-connector-nodejs/pull/820

sfc-gh-ext-simba-jy avatar Apr 19 '24 19:04 sfc-gh-ext-simba-jy