snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

Typings Files

Open kostenickj opened this issue 5 years ago • 3 comments

Would be extremely helpful, especially when using typescript

kostenickj avatar Jun 19 '19 20:06 kostenickj

Can we get some movement on this? My company is looking to use Typescript with the Snowflake Node Connector, but there is none and I don't want to make any assumptions. It also doesn't allow for intellisense in VSCode.

casey-largent avatar Sep 25 '19 20:09 casey-largent

We don't have a plan in the short term.

smtakeda avatar Sep 25 '19 20:09 smtakeda

@smtakeda Are folks are interested in using typescript in the package - I can submit PRs to update the code (would be a series of PRs - one per file : to make reviews and merging simpler). This would generate typings automatically and also add type safety to the code. As part of the verification - we can test whether the current js file and the generated js file match.

sshivananda avatar Aug 10 '20 07:08 sshivananda

Are there still issues with TypeScript types? I found @types/snowflake-sdk package, but i'm wondering about its quality (just started looking into Snowflake, so i havent tried it myself)

atsu85 avatar Jan 22 '23 17:01 atsu85

seeing that we did not have short term plans for this in 2019 and after 3.5 years, there are still no plans for it to my best knowledge , furthermore @types/snowflake-sdk seems to implement the requirement

considering all of the above, I'm now closing this issue . will reopen/update should the above change.

sfc-gh-dszmolka avatar Feb 25 '23 07:02 sfc-gh-dszmolka

@sfc-gh-dszmolka Do you maintain @types/snowflake-sdk? I am trying to add arrayBindingThreshold connection option and forced to any cast.

edit: i made my own type if that makes the question clearer:

import snowflakeSdk from 'snowflake-sdk'; // "@types/snowflake-sdk": "^1.6.12",

export type SnowflakeConnectionOptions = {
  arrayBindingThreshold?: number
} & snowflakeSdk.ConnectionOptions;

brianzinn avatar Mar 21 '23 17:03 brianzinn

hi @brianzinn no we do not maintain it (for now at least). their CODEOWNERS file suggests maybe you could try to contact these folks:

/types/snowflake-sdk/                                     @htunnicliff @orellabac @boatilus @briangottfried

sfc-gh-dszmolka avatar Mar 21 '23 17:03 sfc-gh-dszmolka