snowflake-connector-nodejs icon indicating copy to clipboard operation
snowflake-connector-nodejs copied to clipboard

SNOW-560911: Unused dependencies as of v1.6.7

Open veltman opened this issue 3 years ago • 1 comments

The package.json for the Snowflake connector includes a large number of dependencies and devDependencies that don't appear to be used anywhere in the codebase or necessary as peerDependencies:

http-signature
https-proxy-agent
json-schema
jsprim
lodash
oscp
follow-redirects
insert-module-globals
vinyl-buffer
vinyl-source-stream

Is there a reason why these dependencies are still required?

Additionally, these two packages are listed in dependencies but are only used in tests, so seem like they should be in devDependencies:

mock-require
test-console

veltman avatar Mar 16 '22 21:03 veltman

Yes, I double that. We pinned snowflake-sdk to 1.6.1 long time ago to avoid unnecessary dependency bloat.

kirillgroshkov avatar Mar 18 '22 15:03 kirillgroshkov

should be fixed by linked PR, closing issue

sfc-gh-dszmolka avatar Jan 14 '23 08:01 sfc-gh-dszmolka