snowflake-connector-net icon indicating copy to clipboard operation
snowflake-connector-net copied to clipboard

SNOW-798828: Target .NET Standard 2.0

Open sfc-gh-ext-simba-lf opened this issue 1 year ago • 2 comments

Description

Change the target framework to .NET Standard 2.0

Checklist

  • [ ] Code compiles correctly
  • [ ] Code is formatted according to Coding Conventions
  • [ ] Created tests which fail without the change (if possible)
  • [ ] All tests passing (dotnet test)
  • [ ] Extended the README / documentation, if necessary
  • [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name

sfc-gh-ext-simba-lf avatar Feb 15 '24 22:02 sfc-gh-ext-simba-lf

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.52%. Comparing base (1465bda) to head (6ca7cec).

:exclamation: Current head 6ca7cec differs from pull request most recent head 7437435

Please upload reports for the commit 7437435 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   85.43%   85.52%   +0.09%     
==========================================
  Files         106      106              
  Lines       10761    10760       -1     
  Branches     1029     1029              
==========================================
+ Hits         9194     9203       +9     
+ Misses       1318     1308      -10     
  Partials      249      249              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 22:02 codecov[bot]

Let's plan to make a note in the readme and with the docs team that although we target Standard 2.0 we do not confirm nor run the tests on Mono/Xamarin/UWP/Unity? @sfc-gh-knozderko @sfc-gh-ext-simba-lf @sfc-gh-ext-simba-hx @sfc-gh-dszmolka

sfc-gh-mhofman avatar Mar 01 '24 10:03 sfc-gh-mhofman

Updated readme with the new supported versions

sfc-gh-ext-simba-lf avatar Jun 20 '24 19:06 sfc-gh-ext-simba-lf