snowflake-connector-net
snowflake-connector-net copied to clipboard
SNOW-878067: Fix retry logic
Description
- Add extra check for retry timeout being infinite
- Check maxHttpRetries before creating the HttpClient
Checklist
- [x] Code compiles correctly
- [x] Code is formatted according to Coding Conventions
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing (
dotnet test
) - [x] Extended the README / documentation, if necessary
- [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.11%. Comparing base (
9d61e81
) to head (c10d13f
). Report is 7 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #866 +/- ##
==========================================
- Coverage 84.35% 84.11% -0.24%
==========================================
Files 88 88
Lines 9336 9401 +65
Branches 874 885 +11
==========================================
+ Hits 7875 7908 +33
- Misses 1235 1260 +25
- Partials 226 233 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.