snowflake-connector-net
snowflake-connector-net copied to clipboard
snowflakedb
[SNOW-1050418] OktaAuthenticator refactor part1
Description
Cleaned up OktaAuthenticator, and prepared for refactoring for object-oriented code.
Checklist
- [x] Code compiles correctly
- [x] Code is formatted according to Coding Conventions
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing (
dotnet test) - [x] Extended the README / documentation, if necessary
- [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coding conventions under link: https://github.com/snowflakedb/snowflake-connector-net/CodingConventions.md not found
Hi @SzymonSmykala could you please provide some context of your changes? Is it just a refactor or you would like to introduce some new functionality? Do you have any business need related to this changes? It's called "part 1" so I suppose you would like to add/refactor more. Could you for example create a Github issue with the high level description what you would like to achieve and link your PR with it? Knowing the broader context would help us a lot. Thanks.
Hi @SzymonSmykala could you please provide some context of your changes? Is it just a refactor or you would like to introduce some new functionality? Do you have any business need related to this changes? It's called "part 1" so I suppose you would like to add/refactor more. Could you for example create a Github issue with the high level description what you would like to achieve and link your PR with it? Knowing the broader context would help us a lot. Thanks.
That's in progress, let me create a GitHub issue.
@sfc-gh-knozderko Here it is : https://github.com/snowflakedb/snowflake-connector-net/issues/864