snowflake-connector-net
snowflake-connector-net copied to clipboard
snowflakedb
Fixes to PUT implementation
Fixes multiple bugs with the PUT command. There are 6 small commits in the branch. Each is separate, but builds upon those prior. Reading them from the oldest to newest, it should be pretty clear. If not, please LMK.
I'm trying to use PUT with pre-gzipped files, and process the server response. Without these fixes, it's not possible. Here's the list
From the issue that I created: #469 Put command has several problems:
Put and Get commands should be case insensitive Put and Get commands fail in asynchronous execute with a unclear error (because they are not supported) Put fails to properly determine existing compression, and then fails to properly put the file to the server When a file is 'put', the server response is mapped to incorrect fields in the result. This renders the result unusable.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is a replacement for PR #470. That PR got old, and rather than resolve the issues, I simply started over from the latest master. @sfc-gh-igarish . I'm sorry that I wasn't able to add you as a reviewer. I seem to lack that permission. Alternatively, it could be my lack of experience with github.
@sfc-gh-igarish, Can you help me work through the automated checks. They appear to be failing on parameters. I suspect that there's a guide somewhere. Can you direct me?
Still PR is a Draft. Can you make it real review? Then I can try to get your PR and see I can tigger the merge gates again.
Done, and thanks.
Barry
From: ilesh garish @.> Sent: Friday, November 11, 2022 7:59 PM To: snowflakedb/snowflake-connector-net @.> Cc: Barry Lovalvo @.>; Author @.> Subject: Re: [snowflakedb/snowflake-connector-net] Fixes to PUT implementation (PR #547)
Still PR is a Draft. Can you make it real review? Then I can try to get your PR and see I can tigger the merge gates again.
— Reply to this email directly, view it on GitHubhttps://github.com/snowflakedb/snowflake-connector-net/pull/547#issuecomment-1312074426, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAI4UWKQDOKR2XAJYYM36J3WH2JOJANCNFSM6AAAAAARTENWMI. You are receiving this because you authored the thread.Message ID: @.@.>>
PR is now merged through this PR: https://github.com/snowflakedb/snowflake-connector-net/pull/556
