snowflake-connector-net icon indicating copy to clipboard operation
snowflake-connector-net copied to clipboard

Add AnsiString support to SFDataConverter.csharpTypeValToSfTypeVal

Open wilcobrouwer opened this issue 3 years ago • 5 comments

Add AnsiString support to SFDataConverter.csharpTypeValToSfTypeVal, fixing #344

wilcobrouwer avatar Jul 19 '21 10:07 wilcobrouwer

@alexrosenfeld10, it looks like we need a maintainer to approve as well. It seems @SimbaGithub and @sfc-gh-hyu are maintainers? If you have some time, could you have a look?

wilcobrouwer avatar Jul 20 '21 08:07 wilcobrouwer

That's correct. I don't work for snowflake I'm just a random person who maintains a private fork of this due to bugs / missing features in the past

alexrosenfeld10 avatar Jul 20 '21 11:07 alexrosenfeld10

@SimbaGithub @sfc-gh-hyu anything we can do to get this merged? It's a rather small PR...

virgilp avatar Aug 18 '21 10:08 virgilp

@wilcobrouwer, thank you for your contribution. Could you please resovle the conflicts so the PR could be tested and merged.

sfc-gh-pbulawa avatar Aug 30 '23 09:08 sfc-gh-pbulawa

@sfc-gh-pbulawa I think we need to drive this

sfc-gh-mhofman avatar Apr 08 '24 13:04 sfc-gh-mhofman