gosnowflake icon indicating copy to clipboard operation
gosnowflake copied to clipboard

Published 20 hours ago • verified publisher icon snowflakedb

Update Go vendors

Open SimbaGithub opened this issue 2 years ago • 1 comments

Description

Update Go vendors

Also fixes vulnerabilities from Sync:

  • #662
  • #659
  • #603
  • #623
  • #607
  • #611
  • #610
  • #609
  • #608
  • #606
  • #604

Checklist

  • [x] Code compiles correctly
  • [x] Run make fmt to fix inconsistent formats
  • [x] Run make lint to get lint errors and fix all of them
  • [ ] Created tests which fail without the change (if possible)
  • [x] All tests passing
  • [ ] Extended the README / documentation, if necessary

SimbaGithub avatar Sep 26 '22 20:09 SimbaGithub

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Sep 26 '22 20:09 github-actions[bot]

Could you please add more descriptions to PR? What is meaning of Update Go Vendors? Also why more than 500 files has been changed? It's not trivial to review 500 files. So once you update the description and confirm build/test works fine, I need to approve based on "good faith".

sfc-gh-igarish avatar Oct 19 '22 18:10 sfc-gh-igarish

Could you please add more descriptions to PR? What is meaning of Update Go Vendors? Also why more than 500 files has been changed? It's not trivial to review 500 files. So once you update the description and confirm build/test works fine, I need to approve based on "good faith".

@sfc-gh-igarish When we get the latest modules using 'go get' it will pull the latest vendor packages which is why we see more than 500 files changed. These are the 3rd party files.

SimbaGithub avatar Oct 19 '22 18:10 SimbaGithub