gosnowflake icon indicating copy to clipboard operation
gosnowflake copied to clipboard

Published 20 hours ago • verified publisher icon snowflakedb

fix: goroutine leak

Open sivchari opened this issue 2 years ago • 4 comments

Description

I fixed goroutine leaks.

releted with #588

  • Close Body.
  • Close Idle connections, if close db.

Checklist

  • [x] Code compiles correctly
  • [x] Run make fmt to fix inconsistent formats
  • [x] Run make lint to get lint errors and fix all of them
  • [x] Created tests which fail without the change (if possible)
  • [x] All tests passing
  • [x] Extended the README / documentation, if necessary

sivchari avatar Sep 05 '22 10:09 sivchari

I was recently troubleshooting a goroutine leak that failed exactly like this, it would be great for this fix to land.

dominicbarnes avatar Sep 13 '22 01:09 dominicbarnes

ping @sfc-gh-jbahk

sivchari avatar Sep 16 '22 08:09 sivchari

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Sep 26 '22 15:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

sivchari avatar Sep 26 '22 16:09 sivchari

Closing as duplicate.

sfc-gh-jbahk avatar Oct 19 '22 18:10 sfc-gh-jbahk