SNOW-636717: Panic inside `snowflakeFileTransferAgent.parseCommand` due to nil pointer dereference

[Thomasdezeeuw]

Issue description

Panic inside snowflakeFileTransferAgent.parseCommand due to nil pointer dereference.

Example code

The relevant code is here: https://github.com/snowflakedb/gosnowflake/blob/d62ff8279fcb2f72c7bd1b0c85354eb64e4e5f88/file_transfer_agent.go#L257

It uses fi and only afterwards check if err is nil, this should be flipped: check the error first, then use fi.

Error log

Can't share.

Configuration

N/A, gosnowflake commit d62ff8279fcb2f72c7bd1b0c85354eb64e4e5f88.

[Thomasdezeeuw]

Any update on this? This is blocking our support for Snowflake...

[Thomasdezeeuw]

It's been two months now... we're trying to support Snowflake, but without a response this makes it quite difficult.

[sfc-gh-dszmolka]

Hi, The driver dev team made a new branch of the driver which is hoped to resolve issues #630, #631, #632. https://github.com/snowflakedb/gosnowflake/tree/fixCipherPanicIssues

Would it be please possible @Thomasdezeeuw to test it and see if it really does ? Would appreciate any feedbacks.

[Thomasdezeeuw]

@sfc-gh-dszmolka I can confirm that the tree fixes this issue. Thanks @sfc-gh-ext-simba-lb!

[sfc-gh-dszmolka]

fixed by #687 earlier