gosnowflake
gosnowflake copied to clipboard
SNOW-1524221 handle nested arrays
Description
SNOW-1524221 Added handling of N-dimensional arrays for N>2 to stringToValue
Checklist
- [x] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
Codecov Report
Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
Project coverage is 83.16%. Comparing base (
52590b9) to head (112ffe8). Report is 2 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| converter.go | 77.77% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 54 54
Lines 12149 12158 +9
==========================================
+ Hits 10104 10111 +7
- Misses 2045 2047 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have read the CLA Document and I hereby sign the CLA
recheck