snorkel
snorkel copied to clipboard
Provide high_precision argument for predict_proba method
Description of proposed changes
This PR adds a new high_precision
argument to the predict_proba
method in LabelModel
.
Related issue(s)
Fixes #1640
Test plan
Repeat the steps as described in #1640. When setting high_precision=False
, the output is True
(there are NaN values). When setting high_precision
to True
, the output is False
.
Checklist
Need help on these? Just ask!
- [x] I have read the CONTRIBUTING document.
- [x] I have updated the documentation accordingly.
- [x] I have added tests to cover my changes.
- [ ] I have run
tox -e complex
and/ortox -e spark
if appropriate. - [x] All new and existing tests passed.
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Hi @simonzli ! Sorry for the late reply. We recently went through some CI upgrades for the checks to become more streamlined. However, because of this, existing PRs such as this one have the old CI checks still attached.
Would you mind rebasing to the new master branch and pushing this PR from there? You can accomplish that by
git pull
git rebase master
git push --force
Thanks!
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Hey @simonzli, checking in again. If you could run
git pull
git rebase main
git push --force
to get the CI working on this branch, I can go ahead and approve and merge it once it passes tests!
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.