snorkel icon indicating copy to clipboard operation
snorkel copied to clipboard

Provide high_precision argument for predict_proba method

Open zehua99 opened this issue 2 years ago • 5 comments

Description of proposed changes

This PR adds a new high_precision argument to the predict_proba method in LabelModel.

Related issue(s)

Fixes #1640

Test plan

Repeat the steps as described in #1640. When setting high_precision=False, the output is True (there are NaN values). When setting high_precision to True, the output is False.

Checklist

Need help on these? Just ask!

  • [x] I have read the CONTRIBUTING document.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [ ] I have run tox -e complex and/or tox -e spark if appropriate.
  • [x] All new and existing tests passed.

zehua99 avatar Oct 11 '21 05:10 zehua99

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 10 '22 12:01 github-actions[bot]

Hi @simonzli ! Sorry for the late reply. We recently went through some CI upgrades for the checks to become more streamlined. However, because of this, existing PRs such as this one have the old CI checks still attached.

Would you mind rebasing to the new master branch and pushing this PR from there? You can accomplish that by

git pull
git rebase master
git push --force

Thanks!

rsmith49 avatar Jan 10 '22 18:01 rsmith49

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 11 '22 12:04 github-actions[bot]

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 08 '22 12:08 github-actions[bot]

Hey @simonzli, checking in again. If you could run

git pull
git rebase main
git push --force

to get the CI working on this branch, I can go ahead and approve and merge it once it passes tests!

rsmith49 avatar Aug 09 '22 02:08 rsmith49

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 07 '22 12:11 github-actions[bot]