Joe Cool comments

Results 179 comments of


                                            Joe Cool

Formats with multiple leading 000s need to preserve these in the output

This is matching 'dec1'.

Generalized engineering notation in E formats don't work as expected

The code currently tries to do this properly but only handles a very limited case `/^#+0.0E\+0$/` of formats, and it doesn't do the crazy thing with 0.0.

Escaped slash is treated as fraction separator

This is from the ECMA Office XML Part 1 specification: / If this symbol is preceded and followed by a number symbol (0, #, and ?), it is interpreted as...

Fraction format gives incorrect results if there is text in the middle

In this case, this pattern is matching because fmt is set to `#??/??`: if((r = fmt.match(/^([#0?]+)( ?)\/( ?)([#0?]+)/))) { then `frac` is returning `[0, 1000, 81]` which is being split...

Fraction format gives incorrect results if there is text in the middle

Here is another couple strange cases, allowed by Excel (but not by the documentation): ? "a" / "b" 8 ? "a" / "b" ?

Fraction format gives incorrect results if there is text in the middle

And just when you thought it can't get any stranger, Excel also suppresses anything after the integer part if the fraction is not needed: format('# "h" ? "a" / "b"...

If only 1 format is given and it doesn't describe a number or date, the "-" sign is missing for negative values

Yes that is the case as you said. This also applies to the "\r" format and also I'm checking all of the ones from valid.tsv and finding more errors. For...

If only 1 format is given and it doesn't describe a number or date, the "-" sign is missing for negative values

I'm using Excel 2010.

Date format 14 should have yyyy to correspond with modern Excel

Fix: t[14]= 'm/d/yyyy'

Date format 14 should have yyyy to correspond with modern Excel

Here is documentation on this. Note there are other related issues mentioned here too: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/0e59abdb-7f4e-48fc-9b89-67832fa11789 Addl Changes: t[22]= 'm/d/yyyy h:mm' t[37]= '#,##0_);(#,##0)' t[38]= '#,##0_);[Red](#,##0)' t[39]= '#,##0.00_);(#,##0.00)' t[40]= '#,##0.00_);[Red](#,##0.00)' t[47]= 'mm:ss.0'...