django-auth-adfs icon indicating copy to clipboard operation
django-auth-adfs copied to clipboard

WIP: Multiple idps

Open peterfarrell opened this issue 3 years ago • 6 comments

WIP for #117

peterfarrell avatar Nov 19 '21 20:11 peterfarrell

Codecov Report

Merging #201 (c45c685) into master (e9808eb) will increase coverage by 0.2%. The diff coverage is 79.5%.

@@           Coverage Diff            @@
##           master    #201     +/-   ##
========================================
+ Coverage    85.9%   86.1%   +0.2%     
========================================
  Files          11      11             
  Lines         497     505      +8     
========================================
+ Hits          427     435      +8     
  Misses         70      70             
Impacted Files Coverage Δ
django_auth_adfs/config.py 87.8% <79.5%> (+0.4%) :arrow_up:

codecov[bot] avatar Nov 19 '21 20:11 codecov[bot]

Hi @peterfarrell. What's the status for this PR? 🙂

sondrelg avatar Dec 29 '21 13:12 sondrelg

@sondrelg Still a WIP and blocked by: https://github.com/jpadilla/pyjwt/issues/433

peterfarrell avatar Jan 03 '22 19:01 peterfarrell

Did you see my comment in #117 @peterfarrell ?

JonasKs avatar Jan 03 '22 19:01 JonasKs

@JonasKs Yes, I did. I don't have the bandwidth to retro-fit anything more than a static list of issuers right now. I'm not familiar with Python-Jose. Does it have the same API as pyJWT?

peterfarrell avatar Jan 03 '22 19:01 peterfarrell

Pretty much, yeah. It is a cleaner implementation, imo.

JonasKs avatar Jan 04 '22 08:01 JonasKs