Case Nelson

Development issues/questions

5

Jumping back into development there's a few issues that I think are difficult and could be better. I do not know deps.edn or kaocha well enough to make these work....

Warn for function calls with probable mixed up parameter names

2

To upvote this issue, give it a thumbs up. See [this list](https://github.com/clj-kondo/clj-kondo/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc) for the most upvoted issues. **Is your feature request related to a problem? Please describe.** Positional arguments are...

## **Links** - [product doc](https://www.notion.so/metabase/Implement-Data-Apps-Permissions-732e27313df14ec99a10d7603026a4f2) - [eng doc](https://www.notion.so/metabase/Permission-Tasks-9fd88a803bed4a3a9a3d75ca1f07b971) ## **Implementation Plan** ### Milestone 1 **Goal: Add new permissions to regex/schema/lists** #### Backend - [ ] ~[Apps] Add /app/* permissions~ -...

## Links - [product doc](https://www.notion.so/metabase/Allow-for-action-customization-and-form-creation-394b911d89d045e7b7287cc40a7d29c3) ## Implementation Plan ### Milestone 1 **Goal**: Add actions to pages, get back to writeback functionality in a non-hacky way #### Backend - [x] #25001...

[Apps] Implicit action pre-fetch values

1

Allows prefetching values to populate an implicit action form (can be extended to prefetch data for other action types later). Queries the model given the pk parameters passed in. Only...

[Apps] Remove emitters

1

Emitters were created when we thought that we would be adding actions to multiple places in metabase. Instead we've coalesced to actions being a core feature of data-apps and are...

[Apps] Handle type errors more cleanly

1

Adds a number of tests for different db datatypes, these can be expanded on as we solve. Catches most exceptions during execution and logs then throws a generic message that...

[Apps] Accept model-ids for scaffolding apps

1

Accept model-ids when scaffolding - does not create implicit actions for existing models - does add action buttons for existing actions on the selected models (`requires_pk` determines if an action...

Formatting decimals is broken when specify locale is not supported

2

expect(0.1000122.toLocaleString()).toEqual "0.1" Expected '0.1,000,122' to equal '0.1'.

Wrap literals around expression refs

2

Fixes #27185 Expression refs need to be handled like field refs as far as type hints in opts are concerned. Otherwise we don't pass the correct parameter types to the...