destreamer icon indicating copy to clipboard operation
destreamer copied to clipboard

/group download very slow to start

Open snobu opened this issue 4 years ago • 4 comments

When trying to download a group

./destreamer.sh -i https://msit.microsoftstream.com/group/GROUP-GUID

Things become very very slow right here

Parsing video/group urls
Fetching videos info...

Which is to be expected since groups usually have an Elon Musk's net worth in Japanese Yen number of videos.

We should either put a cap on it or allow people to pass -limit and -offset parameters (better naming welcome) so the API spraying is a bit more controlled.

snobu avatar Jan 13 '21 19:01 snobu

We could create an hidden "archive" file that keep track of group UUIDs and to which index the last video arrived

lukaarma avatar Jan 13 '21 19:01 lukaarma

Destremer shall remain stateless. Well, except login cookies.. necessary evil. Group downloads are rare... i hope, so let's put in minimal effort... for maximum satisfaction :)

snobu avatar Jan 13 '21 20:01 snobu

We could use the async nature of JS and request them slowly in the background while downloading the others? Or we could do what you suggested, after the end of February, when I'm done with the exams I could take a look

lukaarma avatar Jan 20 '21 08:01 lukaarma

@snobu maybe this could be solved implementing it as #333 suggests, adding a "afterDate" argument.

lukaarma avatar Mar 13 '21 22:03 lukaarma