ftd2xx icon indicating copy to clipboard operation
ftd2xx copied to clipboard

No unit tests for aio module

Open krister-ts opened this issue 3 years ago • 3 comments

The aio module was not added to the unit tests. As it is now, both FTD2XX classes inherit from the same base class. I don't think this is too important until the aio module is substantially different.

I think we should keep this issue open as a reminder until the right PR comes along.

krister-ts avatar Mar 02 '21 18:03 krister-ts

@snmishra Do you want to create a milestone to change the aio module to make use of the asyncio.Transport and asyncio.Protocol like pyserial-asyncio? I think that would be the time to make serious tests for aio.

krister-ts avatar Mar 03 '21 19:03 krister-ts

UPDATE: I am working on making the asyncio.Transport!!

@snmishra

So I finally started using asyncio.Protocol at work for TCP connections using proprietary binary protocol. I've made a transport by copying from pyserial-asyncio and hacking it up a bit. It works. I just need to figure out what I've bypassed and what the equivalents for d2xx should be.

Don't be surprised if you get a PR soon. In the meantime, could you look at licensing? I don't know much about that sort of thing... Is it as simple as crediting the pyserial team for most of the code?

krister-ts avatar Feb 19 '22 00:02 krister-ts

@krister-ts Sounds good. Looks like pyserial-asyncio is a BSD 3 Clause license. It should be compatible with MIT License. I'm no expert on licensing either. Anote crediting pyserial-asyncio project and reference to their license should be good enough.

snmishra avatar Feb 19 '22 01:02 snmishra

@snmishra Would it make sense to make this a new project? This is what pyserial-asyncio does. I hope that no one is relying on the aio module yet since it is experimental.

krister-ts avatar Aug 11 '23 21:08 krister-ts

@snmishra Maybe you could make an organization (on the free plan) called ftd2xx to keep both projects under the same umbrella?

krister-ts avatar Aug 11 '23 21:08 krister-ts

Moved mine.

snmishra avatar Sep 15 '23 15:09 snmishra

Moved mine.

I don't have permission to transfer mine yet

krister-ts avatar Sep 15 '23 16:09 krister-ts

Added you as a member, hope that works.

snmishra avatar Sep 15 '23 20:09 snmishra